Update Custom Set to follow new standard suite #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let set1 = CustomSet::new(vec![1, 2, 3, 4]); | ||
| let set2 = CustomSet::new(vec![2, 3, 4, 5]); | ||
| assert!(set1 != set2); | ||
| fn false_when_the_element_is_in_the_set() { |
|
Good on test content, I think (again I didn't exhaustively check that every single test that's present in custom-set.json is present here). small comments on test names |
Details about the updated test suite are at exercism/problem-specifications#232 This commit brings our tests in line with the new standard and removes now-unnecessary code from the example solution
IanWhitney
force-pushed
the
update_custom_set
branch
from
e4fa386
to
8c197fc
Compare
| let set1 = CustomSet::new(vec![1, 2, 3, 4]); | ||
| let set2 = CustomSet::new(vec![3, 2, 5]); | ||
| assert_eq!(set1.union(&set2), CustomSet::new(vec![1, 2, 3, 4, 5])); | ||
| fn difference_of_two_non_empty_sets_is_elements_only_in_first_set_one() { |
There was a problem hiding this comment.
missed this - can remove one suffix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details about the updated test suite are at
exercism/problem-specifications#232
This commit brings our tests in line with the new standard and removes
now-unnecessary code from the example solution