Secret Handshake approach #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exercises/practice/secret-handshake/.approaches/iterate-once/snippet.txt
|
@ErikSchierboom: Rust approach for Secret Handshake ready for review. |
Comment on lines
+7
to
+24
| pub fn actions(n: u8) -> Vec<&'static str> { | ||
| let (mut action, action_incr, end) = match n & REVERSE_SIGNS { | ||
| 0 => (0, 1, 4), | ||
| _ => (3, -1, -1), | ||
| }; | ||
| let mut output: Vec<&'static str> = Vec::new(); | ||
|
|
||
| loop { | ||
| if action == end { | ||
| break; | ||
| } | ||
| if (n & (1 << action)) != 0 { | ||
| output.push(SIGNS[action as usize]) | ||
| } | ||
| action += action_incr | ||
| } | ||
| output | ||
| } |
There was a problem hiding this comment.
I must admit that I'm not well-versed in Rust, but to me this is very hard to read. It seems to almost obscure the logic. Is this an idiomatic way to solve the exercise in Rust? What about something simple like: https://exercism.org/tracks/rust/exercises/secret-handshake/solutions/aciba90?
There was a problem hiding this comment.
There are simpler approaches which don't offer as much in pedagogic value. Since I only did one approach, I used one which is not exactly unidiomatic, but which afforded more in the way of explanation.
There was a problem hiding this comment.
It is an interesting approach
ErikSchierboom
approved these changes
Mar 3, 2023
dem4ron
pushed a commit
to dem4ron/rust-exercism
that referenced
this pull request
Mar 9, 2023
Add approach to `secret-handshake`
This was referenced Mar 9, 2023
dem4ron
pushed a commit
to dem4ron/rust-exercism
that referenced
this pull request
Mar 9, 2023
Add approach to `secret-handshake`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An approach for Secret Handshake.