Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CI #10

Merged
merged 6 commits into from
Nov 14, 2022
Merged

feat: Add CI #10

merged 6 commits into from
Nov 14, 2022

Conversation

1ethanhansen
Copy link
Contributor

It is working on all architectures on my fork

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. The Windows build is not working BTW because it doesn't have bash installed by default (it runs powershell): https://github.com/exercism/vlang/actions/runs/3446525018/jobs/5751533877

I'd either remove Windows, or add a PowerShell or batch script file specific to Windows.

Let me know which you prefer.

@1ethanhansen
Copy link
Contributor Author

Lovely. The Windows build is not working BTW because it doesn't have bash installed by default (it runs powershell): https://github.com/exercism/vlang/actions/runs/3446525018/jobs/5751533877

I'd either remove Windows, or add a PowerShell or batch script file specific to Windows.

Let me know which you prefer.

Ah yep. Weird that it fails quietly like that. I'll just pull windows off, as long as it runs in a bash/zsh environment it should be okay

.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@ee7
Copy link
Member

ee7 commented Nov 11, 2022

The Windows build is not working BTW because it doesn't have bash installed by default (it runs powershell).

Bash is installed in the Windows GitHub Actions environment. It's just that PowerShell is the default.

Better approach: if the script works on Windows, we should be able to run it on all 3 platforms by specifying bash explicitly.

@1ethanhansen
Copy link
Contributor Author

The Windows build is not working BTW because it doesn't have bash installed by default (it runs powershell).

Bash is installed in the Windows GitHub Actions environment. It's just that PowerShell is the default.

Better approach: if the script works on Windows, we should be able to run it on all 3 platforms by specifying bash explicitly.

Ah nice good to know, thank you!

Apply suggestions from code review

Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com>
@ee7
Copy link
Member

ee7 commented Nov 11, 2022

No problem. Looks like the Windows build passes now - nice.

Just in case it's handy, the source of truth for what's installed on the Windows image is here.

Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But I haven't tested bin/test locally.

Some small nitpicks.

.github/workflows/test.yml Outdated Show resolved Hide resolved
bin/test Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
bin/test Show resolved Hide resolved
security and shellcheck considerations

Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com>
@ErikSchierboom ErikSchierboom merged commit 56b00c8 into exercism:main Nov 14, 2022
@ErikSchierboom
Copy link
Member

Great!

@1ethanhansen 1ethanhansen deleted the add-ci branch November 14, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants