Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pangram: missing edge case #222

Closed
8 tasks done
kytrinyx opened this issue Apr 9, 2016 · 4 comments · Fixed by #228
Closed
8 tasks done

pangram: missing edge case #222

kytrinyx opened this issue Apr 9, 2016 · 4 comments · Fixed by #228

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Apr 9, 2016

@helenst came across a solution that had a bug that the test suite didn't catch. It's addressed in exercism/python#331

The solution worked by accident because 'the quick...' happens to be alphabetically greater than 'abcdef...'.

Here's the test case that was added:

def test_invalid_pangram(self):
    self.assertFalse(
        is_pangram('the quick brown fish jumps over the lazy dog'))

We need to:

  • update the canonical data - https://github.com/exercism/x-common/blob/master/pangram.json
  • draft a detailed issue
    • describes the problem that was found
    • describes the fix
    • links to the canonical data (and mentions that it has been updated with the new test cases)
    • suggests that the exercise should be fixed to include these test cases
    • links to this specific issue (so we get a visual todo list)
  • submit the issue to the relevant tracks using blazon
@kytrinyx
Copy link
Member Author

I'm reopening this, since we haven't put together the issue text to be blasted across all the relevant repositories with blazon.

@IanWhitney
Copy link
Contributor

Yay for Blazon.

@kotp
Copy link
Member

kotp commented Jun 30, 2016

#284 hopefully helps clarifies this.

@behrtam
Copy link
Contributor

behrtam commented Nov 3, 2016

All tracks have incorporated the change, even the java track have merged the change they just didn't close the issue. So we could close this here, right?

@Insti Insti closed this as completed Nov 6, 2016
emcoding pushed a commit that referenced this issue Nov 19, 2018
Added roman numerals test generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants