Fix weird Firefox intersectionRatio issue #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the previous strategy, in rare circumstances Firefox's IntersectionObserver implementation seems to think there is still overflow even when a container is scrolled all the way to one end.
It would report an IntersectionObserver entry with an
intersectionRatio
of 0 andisIntersecting
of true, which doesn't really make any sense.I suspect it's due to non-integer element sizes (like if you have an element whose width is purely based on its text content, it could get a width like
120.45
).Either adding another threshold entry of
0
and also checkingintersectionRatio
both seem to fix it. I'm doing both to play it safe.