Log info about the app version and build mode at the app's start [ECR-3150] #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
approved these changes
May 24, 2019
dmitry-timofeev
approved these changes
May 24, 2019
| // Returns the exact value of the `version` field from the library's Cargo.toml configuration file. | ||
| fn get_lib_version() -> &'static str { | ||
| /// Returns the exact value of the `version` field from the library's Cargo.toml configuration file. | ||
| pub fn get_lib_version() -> &'static str { |
There was a problem hiding this comment.
Shall it be moved to utils for exonum-java to depend on it 🤔 ?
There was a problem hiding this comment.
I was also thinking about this but didn't end up with a name for a module except "misc", "common", "other" etc 🙃
dmitry-timofeev
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
App's version and build mode are logged with level
INFOat the app start.See: https://jira.bf.local/browse/ECR-3150
Definition of Done