Skip to content

Conversation

bullet-tooth
Copy link
Contributor

Overview


Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 86.775% when pulling 8876dbb on jlc/v0.2.0-release into 88565b1 on master.

<properties>
<!-- Project configuration -->
<ejb.version>0.6.0</ejb.version>
<ejb.version>0.7.0-SNAPSHOT</ejb.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why if there is no such need (= there are no things from 0.7.0-s the light client needs)? It will make it impossible to, say, release 0.3.0 if 0.7.0 has not come out yet (= 0.3.0 will require downgrading to 0.6.0, switching the version back and forth).

Copy link
Contributor

@dmitry-timofeev dmitry-timofeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll modify that and merge

@dmitry-timofeev dmitry-timofeev deleted the jlc/v0.2.0-release branch May 27, 2019 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants