Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security]: enable CI (GitHub Actions) on external contributions #630

Closed
ldez opened this issue Apr 29, 2024 · 0 comments · Fixed by #627
Closed

[Security]: enable CI (GitHub Actions) on external contributions #630

ldez opened this issue Apr 29, 2024 · 0 comments · Fixed by #627

Comments

@ldez
Copy link
Contributor

ldez commented Apr 29, 2024

#627 (comment)

Our process prioritizes validating external code before CI runs.

Currently, you never run CI on external contributions.
So that means after reviewing a PR you run it locally on your computer.
I think that is a security problem more than using GitHub Action on PR from the forks.

The run of the GitHub Actions is controlled by repository settings:

Screenshot

https://github.com/exoscale/egoscale/settings/actions

You should check this option "Require approval for all outside collaborators" and the CI will only run after a CI approval (not a PR approval).

Also, the secrets are never used with a PR from forks, so using forks instead of branches is a lot more secure.
Creating PR from a branch of a repository allows access to secrets, this is a security problem.

I think you should update your security practices and policies.

Related to #627

@ldez ldez changed the title [Request]: enable CI (GitHub Actions) on CI [Security]: enable CI (GitHub Actions) on CI Apr 29, 2024
@ldez ldez changed the title [Security]: enable CI (GitHub Actions) on CI [Security]: enable CI (GitHub Actions) on external contributions Apr 29, 2024
pierre-emmanuelJ pushed a commit that referenced this issue May 1, 2024
Runs the CI on PR coming from forks.

Fixes #630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant