Replace PHP CS Fixer ruleset #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmaudo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP CS Fixer rule set is customized for that project and contains several rules that are not common in the industry.
For example, it requires all tests to have the
@coversannotation, which restricts the classes that are included in the coverage reports.This PR aims to replace this set by the Symfony rule set, on which the PHP CS Fixer rule set is based.
Its coding style is almost a standard in PHP, since Symfony is one of the largest projects and its libraries are widely used.
In addition, its rules are stable, avoiding unnecessary changes in our code base.