Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygls > 1.0.x breaks version checks #30

Open
shadeMe opened this issue Oct 25, 2023 · 2 comments
Open

pygls > 1.0.x breaks version checks #30

shadeMe opened this issue Oct 25, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@shadeMe
Copy link
Collaborator

shadeMe commented Oct 25, 2023

pygls 1.1 seems to have removed the __version__ attribute from the top-level module, which breaks the validation code.

@shadeMe shadeMe added the bug Something isn't working label Oct 25, 2023
@adrianeboyd
Copy link

Checking versions for python 3.7+ is annoying due to the lack of importlib.metadata in python 3.7.

If you switch this to python 3.8+ you can use importlib.metadata instead. For python 3.7+ you could use importlib_metadata from spacy.compat. You'd have to refactor the version checking code a bit to import spacy first/separately.

@b2m
Copy link

b2m commented Dec 16, 2024

So a "quick fix" would be to install pygls>=1.0.0,<1.1.0.

But as Python 3.7 and 3.8 have reached their EOL is supporting them in this extension still an issue?
If not do you accept pull requests in this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants