Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend to typer<1.0.0 to match SpaCy #87

Merged

Conversation

aymenkrifa
Copy link
Contributor

@aymenkrifa aymenkrifa commented May 10, 2024

Description

FastAPI standard (starting from version 0.111.0) added a fastapi-cli package that now only supports the typer package to be typer >= 0.12.3, installing both FastAPI (>=0.111.0) and SpaCy causes a conflict since weasel's Typer version is 0.10.0
-> Extend the Typer version to typer<1.0.0 to match SpaCy's version.

Types of change

Package upgrade

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the test suite, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg
Copy link
Member

Thanks! We'll get this fixed.

@svlandeg
Copy link
Member

svlandeg commented May 14, 2024

It looks like the CI is failing because of an unrelated issue, I'll look into that separately first.

[EDIT: fixed 🎉]

@svlandeg svlandeg merged commit 72431c9 into explosion:main May 14, 2024
18 checks passed
@svlandeg
Copy link
Member

Weasel v0.4.1 is now released!

@aymenkrifa
Copy link
Contributor Author

Awesome, thank you @svlandeg 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants