-
Notifications
You must be signed in to change notification settings - Fork 51
Add ability to block/wait until standalone build succeeds or fails #102
Conversation
This is awesome! Thanks for the pull request @mglagola. Before starting to wait, we could show the "You can monitor the build at..." so people can go view the logs while waiting. @anp had an idea that we could make this the default now, since it's almost always what you'd want. We can have |
src/commands/build/BaseBuilder.js
Outdated
case 'pending': | ||
case 'started': | ||
case 'in-progress': | ||
log(`Standalone app is still building, checking again in ${interval}s ...`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sometimes gets repeated quite a few times. Maybe we can just show a spinner and some message like this?
Waiting for build to complete. You can press Ctrl+C to exit.
We use the @expo/simple-spinner
library for spinners, here's an example of how to use it:
exp/src/commands/diagnostics.js
Lines 16 to 20 in 95f81c9
simpleSpinner.start(); | |
const { url } = await Diagnostics.getDeviceInfoAsync({ | |
uploadLogs: true, | |
}); | |
simpleSpinner.stop(); |
@fson Lmk what you think, added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I’m going to give this a final test in the morning and merge after that 👍
@fson - Per our discussion to merge some of [exptool](https://github.com/mglagola/exptool) functionality with `exp`! Closes #102 fbshipit-source-id: b55ef37
Merged. Thanks again @mglagola, this makes the build command so much nicer! |
@fson - Per our discussion to merge some of [exptool](https://github.com/mglagola/exptool) functionality with `exp`! Closes expo/exp#102
@fson - Per our discussion to merge some of [exptool](https://github.com/mglagola/exptool) functionality with `exp`! Closes expo/exp#102
@fson - Per our discussion to merge some of exptool functionality with
exp
!