Skip to content
This repository has been archived by the owner on Oct 5, 2018. It is now read-only.

Add ability to block/wait until standalone build succeeds or fails #102

Closed
wants to merge 2 commits into from
Closed

Add ability to block/wait until standalone build succeeds or fails #102

wants to merge 2 commits into from

Conversation

mglagola
Copy link
Contributor

@mglagola mglagola commented Mar 1, 2018

@fson - Per our discussion to merge some of exptool functionality with exp!

@fson
Copy link
Contributor

fson commented Mar 1, 2018

This is awesome! Thanks for the pull request @mglagola.

Before starting to wait, we could show the "You can monitor the build at..." so people can go view the logs while waiting.

@anp had an idea that we could make this the default now, since it's almost always what you'd want. We can have --no-wait, which would revert back to the old behavior (exit once the build has started).

case 'pending':
case 'started':
case 'in-progress':
log(`Standalone app is still building, checking again in ${interval}s ...`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sometimes gets repeated quite a few times. Maybe we can just show a spinner and some message like this?

Waiting for build to complete. You can press Ctrl+C to exit.

We use the @expo/simple-spinner library for spinners, here's an example of how to use it:

simpleSpinner.start();
const { url } = await Diagnostics.getDeviceInfoAsync({
uploadLogs: true,
});
simpleSpinner.stop();

@mglagola
Copy link
Contributor Author

mglagola commented Mar 1, 2018

@fson Lmk what you think, added simpleSpinner, changed --wait to --no-wait and made sure You can monitor the build at... is always logged

Copy link
Contributor

@fson fson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I’m going to give this a final test in the morning and merge after that 👍

@fson fson closed this Mar 2, 2018
expbot pushed a commit that referenced this pull request Mar 2, 2018
@fson - Per our discussion to merge some of [exptool](https://github.com/mglagola/exptool) functionality with `exp`!

Closes #102

fbshipit-source-id: b55ef37
@fson
Copy link
Contributor

fson commented Mar 2, 2018

Merged. Thanks again @mglagola, this makes the build command so much nicer!

fson pushed a commit to expo/expo-cli that referenced this pull request Aug 16, 2018
@fson - Per our discussion to merge some of [exptool](https://github.com/mglagola/exptool) functionality with `exp`!

Closes expo/exp#102
fson pushed a commit to expo/expo-cli that referenced this pull request Aug 23, 2018
@fson - Per our discussion to merge some of [exptool](https://github.com/mglagola/exptool) functionality with `exp`!

Closes expo/exp#102
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants