Ability to stdout standalone app url via url:ipa and url:apk cmds #103
Conversation
mglagola
changed the title
src/commands/url.js
Outdated
| fp.getOr([], 'jobs') | ||
| )(res); | ||
| if (url) { | ||
| console.log(url); |
There was a problem hiding this comment.
Using console.log because log has a prefix ([exp] [timestamp] <msg>) that will interfere with outside commands like curl.
There was a problem hiding this comment.
IIRC you can use log.nested() to print without the prefix.
src/commands/url.js
Outdated
|
|
||
| program | ||
| .command('url:ipa [project-dir]') | ||
| .alias('ui') |
There was a problem hiding this comment.
I know we use these short aliases in a bunch of commands (I'm not a big user of them myself), but I think exp ui might be confusing. Maybe let's just add url:ipa and url:apk for now and no aliases?
src/commands/url.js
Outdated
| if (url) { | ||
| console.log(url); | ||
| } else { | ||
| throw new Error(`No ${platform} binary file found.`); |
There was a problem hiding this comment.
This message could tell they can use exp build:${platform} to create one.
src/commands/url.js
Outdated
| fp.getOr([], 'jobs') | ||
| )(res); | ||
| if (url) { | ||
| console.log(url); |
There was a problem hiding this comment.
Please use the log functions to log.
|
@fson pushed up those changes |
src/commands/url.js
Outdated
| program | ||
| .command('url:ipa [project-dir]') | ||
| .description('Displays the standalone iOS binary URL you can use to download your app binary') | ||
| .allowOffline() |
There was a problem hiding this comment.
These new commands probably shouldn't call allowOffline (it enables the --offline flag), because they require an internet connection and being signed in to Expo to work.
|
@fson LMK if any other changes are needed |
|
Everything looks great now. Could you resolve the conflicts in this branch so I can then merge it? |
|
@fson fixed conflicts! |
@fson - Per our discussion to merge some of [exptool](https://github.com/mglagola/exptool) functionality with `exp`! This functionality will allow for commands like: ```bash curl -o app.ipa "$(exp url:ipa)" curl -o app.apk "$(exp url:apk)" ``` Closes #103 fbshipit-source-id: bc7289a
|
Thanks! |
@fson - Per our discussion to merge some of [exptool](https://github.com/mglagola/exptool) functionality with `exp`! This functionality will allow for commands like: ```bash curl -o app.ipa "$(exp url:ipa)" curl -o app.apk "$(exp url:apk)" ``` Closes expo/exp#103
@fson - Per our discussion to merge some of [exptool](https://github.com/mglagola/exptool) functionality with `exp`! This functionality will allow for commands like: ```bash curl -o app.ipa "$(exp url:ipa)" curl -o app.apk "$(exp url:apk)" ``` Closes expo/exp#103
@fson - Per our discussion to merge some of exptool functionality with
exp!This functionality will allow for commands like: