This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[expo-cli] Generate-module fixes and improvements #2548
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Continuation of #2510 (that fix was rather critical). Trying to make
expo generate-module
more universal and generic.Changes
@next
and@latest
(shall we make it less restrictive to accept any string as tag?)expo-
prefix.EXPackageName
(it didn't always addEX
prefix before) - idk if it's desirable change.Test plan
Tested manually using custom testing template (custom package names etc). Checked if all renamings work as expected.