Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[ENG-8317][cli] deprecate publish:* #4685

Merged
merged 3 commits into from
Apr 21, 2023
Merged

[ENG-8317][cli] deprecate publish:* #4685

merged 3 commits into from
Apr 21, 2023

Conversation

quinlanj
Copy link
Member

Why

  • expo publish:* commands should say they’re deprecated and replaced by eas
  • when someone runs one of these commands, print a link to the sunset blog post

How

  • update command description
  • print deprecation notice on expo publish:*

Test Plan

Screenshot 2023-04-17 at 11 32 16 PM

@linear
Copy link

linear bot commented Apr 18, 2023

ENG-8317 Deprecate "expo publish" in Expo CLI and more cleanup

I noticed a few things with the expo-cli package:

  1. Version 6.3.6 is the most recent but latest points to 6.3.2. any issues pointing latest at 6.3.6?
  2. Best I can tell, the package isn’t marked as deprecated. Seems like a good idea to do that?
    1. and maybe print out a deprecation message every time the command is run?
    2. SDK 45 (may 5) was the first release with the beta versioned CLI, SDK 46 (aug 1) was the first release with it out of beta. i believe apple isn’t going to support SDK 45 apps after april 25 because of the xcode requirement so people need to upgrade to 46+ anyway very soon.
  3. The expo publish:* commands don’t say they’re deprecated and replaced by eas. Let’s do that.
  4. Similarly, when someone runs one of these commands, print a link to the sunset blog post
  5. The expo build:* commands can be removed. even if we don’t want to do a lot of code cleanup work, let’s just remove them from the invokable commands
    1. Evan had a good point that these commands serve as "redirects" to EAS Build. If someone reads an outdated guide on "expo build" they'll end up at EAS Build because of these stub commands.

Co-authored-by: James Ide <ide@users.noreply.github.com>
@quinlanj quinlanj merged commit 25f37af into main Apr 21, 2023
@quinlanj quinlanj deleted the @quin/deprecatePublish branch April 21, 2023 04:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants