Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[doctor] clean up check names #4727

Merged

Conversation

keith-kurak
Copy link
Contributor

@keith-kurak keith-kurak commented Jul 5, 2023

Why

Fulfills https://linear.app/expo/issue/ENG-8979/unify-expo-doctor-test-descriptions

How

Changed the check names as suggested, trying to explain a little more specifically/ plainly what they were doing.

In the long run, I kind of want to get away from these descriptions entirely. They were originally an attempt to componentize things that were tested together, but now they result in sometimes having to worry about how the technical category (e.g., a deep dependency check) matches or doesn't match with the logical category of the check (e.g., support package version check vs. checking for unimodules, various categories of things that could all be considered "package.json checks", etc.).

Test Plan

image

@linear
Copy link

linear bot commented Jul 5, 2023

ENG-8979 Unify expo-doctor test descriptions

image.png

  • Validate Expo Config - capital C
  • Check for conflicting global packages says 'in project', the incompatible packages one doesn't
  • I don't understand what line 9 is trying to say
  • What's the difference between 'check', 'validate' and 'verify'?

@keith-kurak keith-kurak marked this pull request as ready for review July 5, 2023 15:04
@brentvatne brentvatne merged commit d5d23c4 into main Jul 5, 2023
@brentvatne brentvatne deleted the keith/eng-8979-unify-expo-doctor-test-descriptions branch July 5, 2023 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants