This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fulfills https://linear.app/expo/issue/ENG-8979/unify-expo-doctor-test-descriptions
How
Changed the check names as suggested, trying to explain a little more specifically/ plainly what they were doing.
In the long run, I kind of want to get away from these descriptions entirely. They were originally an attempt to componentize things that were tested together, but now they result in sometimes having to worry about how the technical category (e.g., a deep dependency check) matches or doesn't match with the logical category of the check (e.g., support package version check vs. checking for unimodules, various categories of things that could all be considered "package.json checks", etc.).
Test Plan