This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
feat: detect bun package manager #4752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
added a commit
to expo/expo
that referenced
this pull request
Sep 8, 2023
# Why Adds Bun as a recognized package manager Sister PR: expo/expo-cli#4752 # How Added `@expo/package-manager` # Test Plan Added `BunPackageManager-test.ts` and added Bun tests to `nodeManagers-test.ts`. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist --------- Co-authored-by: Evan Bacon <baconbrix@gmail.com> Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
brentvatne
pushed a commit
to expo/expo
that referenced
this pull request
Sep 11, 2023
Adds Bun as a recognized package manager Sister PR: expo/expo-cli#4752 Added `@expo/package-manager` Added `BunPackageManager-test.ts` and added Bun tests to `nodeManagers-test.ts`. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> --------- Co-authored-by: Evan Bacon <baconbrix@gmail.com> Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
brentvatne
approved these changes
Sep 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on expo/expo#24168
Why
Detect bun package manager in
create-expo-appHow
npm_config_user_agentforbunTest Plan
Tests have been addeed to
resolvePackageManager.test.ts