settings locals variables on a partial no longer works

[nick]

I just updated from tag 1.0.0rc4 and my partials no longer work properly. Example partial:

!= partial('restaurants/_restaurant_js.html.ejs', {locals: {restaurant: restaurant.data}})

In the partial, I can't access any properties of the 'restaurant' variable. But it worked fine before the upgrade. It looks like locals are no longer being set properly

[tj]

shit, im on it

[tj]

seems fine actually ...

I just noticed you have .html.ejs, what version of express did you have before? things have changed a bit, check out http://expressjs.com/migrate.html

[nick]

I checked again - it works fine for strings and numbers, but I can't seem to access sub properties of objects. So in my case, if restaurant.data = "ok", that works, but if it's {_id: "chutneys"}, I can't access restaurant._id in the partial.

[tj]

:s weird wtf

[tj]

this test should confirm that what you are mentioning is fine...

    'test #partial() locals': function(assert){
    var app = create();

    app.get('/', function(req, res, next){
        res.send(res.partial('pet-count.jade', {
          partial: true,
          layout: false,
          locals: {
            pets: {
              length: 5
            }
          }
        }));
    });

    assert.response(app,
        { url: '/' },
        { body: 'We have 5 cool pets\n' });
},

so im not to sure :s

[nick]

OK, the reason was because I have a variable called 'restaurant' in my main view and a different on in the partial. This used to work but a recent change means local variables in a partial get overwritten if there is a variable with the same name in the main view

[tj]

ah i see. that makes sense. I should swap the precedence then

[nick]

cheers, sorry for the confusion. Was a weird looking bug, heh

[tj]

Fixed partial local inheritance precedence. Closed by 33136c6

[tj]

no no, thanks man, it seemed like a non-issue at first, but definitely a good catch