Add ability to set 'json spaces' on res.json #2469
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
json spaces
can only be set at an application level, but it would be nice to be able to override that setting on the response level. For example, in my situation I'd like the root of an API route to pretty print JSON (app.set('json spaces', 2)
), but an actual response to be minified (app.get('json spaces', 2)
.I found a way to get around this by setting the
json spaces
on a response as so:This works well, but it would be nice to set
json spaces
directly onres.json
in the same way you can set something likeContent-type
. This PR allows you to do this - for example:If
json spaces
is not set on a givenresponse
it falls back to the application'sjson spaces
setting.