Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using let instead of var to declare the counter in the for loop. #3189

Closed
wants to merge 1 commit into from
Closed

Conversation

MarkAdell
Copy link

Using let instead of var to declare the counter in the for loop in order to keep the counter local to the loop.

@hacksparrow
Copy link
Member

@MarkAdell as you can see from the integration tests, let is not supported in Node 0.10 and 0.12, by default. Express aims to be very backward compatible, so 0.10 and 0.12 support is required as of the current version.

@notrab
Copy link
Contributor

notrab commented Jan 31, 2017

I can imagine the Express API being reduced with new ES6 sprinkles. It may also help adopt and push this new syntax.

But I like how Express aims to cover as much Node as possible. I think v5 could drop older Node support as v4 is very solid and will be ran alongside 5 for years in the same way 3&4 did. Be good to see what the community thinks, I think there is an issue asking for thoughts and discussion anyhow!

@dougwilson dougwilson added the pr label Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants