Limit the maxAge of cookies to prevent cookie errors #4931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cookie` library [now validates expires to be valid dates](jshttp/cookie@042073f). This PR helps prevent unexpected errors when someone sets the maxAge to some crazy high number.
dougwilson
suggested changes
Jun 16, 2022
There was a problem hiding this comment.
Hello, and thank you for your pull request! This is definitely an issue, as the data input leads to a bad error message. Would you be willing to add at lest one test for this condition to our test suite? In addition, I don't think altering the user's input is expected. This should likely throw an error if the maxAge input is out of bounds for setting the cookie.
|
Thinking more about this, if we are okay with an error the current status quo is prob fine imo -- because the underlying cookie library throws a reasonable error. Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cookielibrary now validates expires to be valid dates. This PR helps prevent unexpected errors when someone sets the maxAge to some crazy high number.