pull req #5284
Closed
pull req #5284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
update router code ! |
UlisesGascon
requested changes
Nov 11, 2023
There was a problem hiding this comment.
Hello @Deepsutariy,
I appreciate your effort in submitting this pull request. However, I've noticed a few issues with the changes you made. It's important to note that Express supports older Node.js versions, which means the use of ES6 syntax like const might pose compatibility problems.
I'm uncertain about the intended outcome of this pull request. To provide better clarity, could you please include some documentation detailing the changes you've made?
Thank you for your understanding and cooperation.
Best regards.
|
|
||
| var express = require('../../'); | ||
| const express = require('express'); |
There was a problem hiding this comment.
Please don't change this reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.