Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send@1.0.0 #5786

Merged
merged 1 commit into from
Aug 9, 2024
Merged

send@1.0.0 #5786

merged 1 commit into from
Aug 9, 2024

Conversation

wesleytodd
Copy link
Member

@wesleytodd wesleytodd commented Jul 25, 2024

This updates send@^1.0.0.

The failure in CI is expected until we land #5595 because send dropped node versions. It looks like we explicitly break <6 with this.

@wesleytodd wesleytodd changed the title WIP: Send 1.x send@1.0.0 Jul 26, 2024
@wesleytodd wesleytodd mentioned this pull request Jul 26, 2024
6 tasks
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to include changes in the History.md?

@wesleytodd
Copy link
Member Author

wesleytodd commented Jul 26, 2024

Yeah we do, that said longer term I really want to get us on a tool to automate this. Release Please ideally. We don't even need to auto publish, but just generating the changelog and opening the PR would be awesome.

EDIT: I will update that when we get the CI working again and are ready to merge.

@wesleytodd
Copy link
Member Author

I think that since we plan on fixing up the CI in separate PRs I don't want to let this sit and have to update the branch again for such a small change which is guaranteed to land. Also, just pushed an update for the history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants