New labels: Move to Magento core / MEQP

[jissereitsma]

After a call between various Magento people, @schmengler and myself, it was suggested that having too many PHPCS repositories is a bad thing. In short, we would be happy if some of our rules are merged into the Magento core or the MEQP ruleset. Another goal could be to minimize the chance of us and them working on the same kind of rules.

Shall we create new labels "Move to Magento core" and "Move to MEQP" because of this?

[schmengler]

"move" in terms of, "we create a PR there instead of implementing it here"? Then I'm against it, as long as the release process of MEQP is so slow. And having rules only in the Magento core is not good either, because we cannot reference them without requiring the whole jungle (i.e. Magento)

[schmengler]

On the other hand, if we know, the MEQP team is already working on it, we should prevent duplicate efforts, so a label like "waiting for Magento" would make sense in that case

[jissereitsma]

@schmengler Well, this needed some discussion anyway. It would be better phrased as in "we create a PR there AND implement it here". In the end, the source can be the exact same (with only some namespaces needing to be changed). But perhaps the phrasing should be "Duplicate to MEQP"?

[ravmenon]

@schmengler Agree that is has been slow accepting pull requests largely due to EQP 2.0 project. Once EQP 2.0 goes live, we will focus attention back to the public MEQP rulesets. This is the preferred github repo for EQP rules as there is also another internal effort to consolidate core M2 phpcs rules and EQP ones which will also be revived post EQP 2.0. It will be in the public github (most likely the one above) so you don't need the full core M2 to run these rules too.