fix memory cost for call operation #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ayrat555
force-pushed
the
fix_memory_cost_for_cost_operation
branch
from
5ebbe73
to
a73ec3b
Compare
masonforest
reviewed
Apr 24, 2018
lib/evm/gas.ex
Outdated
| machine_state | ||
| ) do | ||
| memory_expansion_cost(machine_state, out_offset, out_length) | ||
| out_memory = memory_expansion_cost(machine_state, out_offset, out_length) |
There was a problem hiding this comment.
nitpick: how about out_memory_cost?
masonforest
reviewed
Apr 24, 2018
lib/evm/gas.ex
Outdated
| out_memory = memory_expansion_cost(machine_state, out_offset, out_length) | ||
| in_memory = memory_expansion_cost(machine_state, in_offset, in_length) | ||
|
|
||
| if out_memory > in_memory, do: out_memory, else: in_memory |
There was a problem hiding this comment.
would max(out_memory, in_memory) work?
masonforest
approved these changes
Apr 24, 2018
masonforest
pushed a commit
that referenced
this pull request
Apr 25, 2018
…tion fix memory cost for call operation
masonforest
pushed a commit
that referenced
this pull request
Apr 25, 2018
…tion fix memory cost for call operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34