New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: place user facing types in the Extism.Sdk namespace #29

Merged

mhmd-azeez merged 2 commits into main from refactor/proper-namespace

Nov 16, 2023

Collaborator

mhmd-azeez commented Nov 2, 2023

Only the types defined by the native runtime should be in the Extism.Sdk.Native namespace
Use file level namespace (this has caused a bit of a mess in the GitHub diff viewer)


          refactor: place user facing types in the Extism.Sdk namespace

2f54bde

mhmd-azeez requested review from zshipko and wikiwong

November 2, 2023 12:23

Collaborator Author

mhmd-azeez commented Nov 8, 2023

This PR is ready for review


          merge main into branch

c561bfb

bhelx approved these changes

View reviewed changes

mhmd-azeez merged commit 5390eb0 into main

3 checks passed

mhmd-azeez deleted the refactor/proper-namespace branch

November 16, 2023 13:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet