Fix stderr being emitted in binary mode & other misc changes #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to test this in arepl first to make sure there's no major bugs |
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
==========================================
+ Coverage 94.88% 94.91% +0.02%
==========================================
Files 1 1
Lines 176 177 +1
Branches 43 44 +1
==========================================
+ Hits 167 168 +1
Misses 9 9
Continue to review full report at Codecov.
|
node 9 is no longer supported
better to match name of childprocess method for consistency
param is already clear
|
Tested successfully in AREPL |
Almenon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite docs saying that stderr is not emitted in binary mode I realized that it was still being emitted. I fixed the code so it matches the docs.