Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--hyperlinks seem to break -l --grid #129

Closed
cafkafk opened this issue Aug 13, 2023 · 1 comment · Fixed by #136
Closed

--hyperlinks seem to break -l --grid #129

cafkafk opened this issue Aug 13, 2023 · 1 comment · Fixed by #136
Labels
errors › invalid output good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cafkafk
Copy link
Member

cafkafk commented Aug 13, 2023 •
edited
Loading

Demonstration
2023-08-13_06-30

In the eza root dir
2023-08-13_06-30_1

But not if we remove --hyperlink
2023-08-13_06-31
@cafkafk
Copy link
Member Author

cafkafk commented Aug 13, 2023

I'm not gonna have time for this right now so this issue is up for grabs

@cafkafk cafkafk added help wanted Extra attention is needed good first issue Good for newcomers errors › invalid output labels Aug 13, 2023
@cafkafk cafkafk mentioned this issue Aug 13, 2023
Merged
@PThorpe92 PThorpe92 mentioned this issue Aug 13, 2023
Open
gierens added a commit to gierens/eza that referenced this issue Aug 13, 2023
@gierens
Fix TextCell building of detailed grid view for hyperlink and icon op…
cea7a43 
…tions

The hyperlink option adds an escape sequence which in the normal TextCell
creation also becomes part of the length calculation. This patch applies
the same logic the normal grid already did, by using the filenames bare
width when a hyperlink is embedded. It also respects the ShowIcons
option just like the normal grid view.

Resolves eza-community#129
@gierens gierens mentioned this issue Aug 13, 2023
Merged
gierens added a commit to gierens/eza that referenced this issue Aug 13, 2023
@gierens
Fix TextCell building of detailed grid view for hyperlink and icon op…
6e5f606 
…tions

The hyperlink option adds an escape sequence which in the normal TextCell
creation also becomes part of the length calculation. This patch applies
the same logic the normal grid already did, by using the filenames bare
width when a hyperlink is embedded. It also respects the ShowIcons
option just like the normal grid view.

Resolves eza-community#129
cafkafk pushed a commit to gierens/eza that referenced this issue Aug 13, 2023
@gierens @cafkafk
fix: TextCell building of detailed grid view for hyperlink and icon o…
0da9b60 
…ptions

The hyperlink option adds an escape sequence which in the normal TextCell
creation also becomes part of the length calculation. This patch applies
the same logic the normal grid already did, by using the filenames bare
width when a hyperlink is embedded. It also respects the ShowIcons
option just like the normal grid view.

Resolves eza-community#129
Omnikron13 pushed a commit to Omnikron13/eza that referenced this issue Mar 17, 2024
@gierens @Omnikron13
fix: TextCell building of detailed grid view for hyperlink and icon o…
90834c9 
…ptions

The hyperlink option adds an escape sequence which in the normal TextCell
creation also becomes part of the length calculation. This patch applies
the same logic the normal grid already did, by using the filenames bare
width when a hyperlink is embedded. It also respects the ShowIcons
option just like the normal grid view.

Resolves eza-community#129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
errors › invalid output good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Hyperlink Details Grid Bug gierens/eza
1 participant
@cafkafk