Fix Hyperlink Details Grid Bug #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gierens
force-pushed
the
bugfix-129-hyperlink-grid
branch
from
cea7a43
to
6e5f606
Compare
…ptions The hyperlink option adds an escape sequence which in the normal TextCell creation also becomes part of the length calculation. This patch applies the same logic the normal grid already did, by using the filenames bare width when a hyperlink is embedded. It also respects the ShowIcons option just like the normal grid view. Resolves eza-community#129
cafkafk
force-pushed
the
bugfix-129-hyperlink-grid
branch
from
b229b86
to
0da9b60
Compare
cafkafk
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hyperlink option adds an escape sequence (https://github.com/eza-community/eza/blob/main/src/output/file_name.rs#L325-L329) which in the normal TextCell creation also becomes part of the length calculation. This patch applies the same logic the normal grid already did (https://github.com/eza-community/eza/blob/main/src/output/grid.rs#L45-L58), by using the filenames bare width when a hyperlink is embedded. It also respects the ShowIcons option just like the normal grid view.
Resolves #129