-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add parameter --path to use project path instead of project name #39
add parameter --path to use project path instead of project name #39
Conversation
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Tests are still missing. |
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 95.56% 95.62% +0.05%
==========================================
Files 8 8
Lines 316 320 +4
==========================================
+ Hits 302 306 +4
Misses 14 14
Continue to review full report at Codecov.
|
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ezbz is this going to be merged soon? Thats exactly what I need 😍 |
This #43 replaces this PR, it is more aligned with project code using enums rather than booleans to allow expanding future values and doesn't add any more unnecessary fields to the data model (either path or name are used not both so need to cache the values in the model when path is not used) |
It's nice to see to get this resolved. If you'd asked, I would have gladly adapted my PR. Are going to release this as 1.1.2? |
Released in 1.1.2 https://raw.githubusercontent.com/ezbz/gitlabber/master/CHANGELOG.md I have to work up the contribution guidelines, will gladly accept help moving forward |
Make it possible to generate folder names based on group and project path instead of group and project name.
Possible FIX #25 and FIX #38.