Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parameter --path to use project path instead of project name #39

Conversation

ziegenberg
Copy link

@ziegenberg ziegenberg commented Jan 19, 2021

Make it possible to generate folder names based on group and project path instead of group and project name.

Possible FIX #25 and FIX #38.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg
Copy link
Author

Tests are still missing.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #39 (d8e1c67) into master (ef989b1) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   95.56%   95.62%   +0.05%     
==========================================
  Files           8        8              
  Lines         316      320       +4     
==========================================
+ Hits          302      306       +4     
  Misses         14       14              
Impacted Files Coverage Δ
gitlabber/cli.py 94.44% <100.00%> (+0.07%) ⬆️
gitlabber/gitlab_tree.py 97.67% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef989b1...d8e1c67. Read the comment docs.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg marked this pull request as ready for review January 19, 2021 21:43
@TheKangaroo
Copy link

@ezbz is this going to be merged soon? Thats exactly what I need 😍

@ezbz
Copy link
Owner

ezbz commented Feb 21, 2021

This #43 replaces this PR, it is more aligned with project code using enums rather than booleans to allow expanding future values and doesn't add any more unnecessary fields to the data model (either path or name are used not both so need to cache the values in the model when path is not used)

@ezbz ezbz closed this Feb 21, 2021
@ziegenberg
Copy link
Author

It's nice to see to get this resolved. If you'd asked, I would have gladly adapted my PR.

Are going to release this as 1.1.2?

@ezbz
Copy link
Owner

ezbz commented Feb 24, 2021

Are going to release this as 1.1.2?

Released in 1.1.2 https://raw.githubusercontent.com/ezbz/gitlabber/master/CHANGELOG.md

I have to work up the contribution guidelines, will gladly accept help moving forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clone into "path" not "name" use project path instead of project name
3 participants