fix: don't skip resolving files imported by other plugins #365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve files imported from non-TS files / other plugins / JS files, such as TS files imported by Svelte files
Could not resolve
TS files without extension (.ts
) from Svelte files #283Details
previously the
allImportedFiles
Set was basically used to skip any files that were imported by other pluginsimporter
(notimportee
)allowJs
JS code, or heck, even regular JS code that Rollup processes without plugins, may actually import TS files@rollup/plugin-node-resolve
with a.ts
extension solved this as a workaroundnode-resolve
then actually transformed by rpt2node-resolve
shouldn't be necessaryCould not resolve
TS files without extension (.ts
) from Svelte files #283resolveId
is actually the last remaining place whereallImportedFiles
was usedfor reference,
allImportedFiles
would be anyinclude
d files as well as TS files that have been transformed (at this point in the build) and their referencesHistorical Context
include
/exclude
when generating declarations #162filter
"missed" declarations as well #347 (comment) and Rollup errorCould not resolve
TS files without extension (.ts
) from Svelte files #283 (comment) and my next comments after both of those