Skip to content
This repository has been archived by the owner on Aug 13, 2022. It is now read-only.

#42 노선 수정 #89

Merged
merged 8 commits into from
Sep 6, 2020
Merged

#42 노선 수정 #89

merged 8 commits into from
Sep 6, 2020

Conversation

0hun
Copy link
Collaborator

@0hun 0hun commented Sep 4, 2020

노선 수정 메소드 추가

노선 수정 메소드 추가
@0hun 0hun requested a review from f-lab-dev September 4, 2020 15:06
@0hun 0hun self-assigned this Sep 4, 2020
@0hun 0hun changed the title #노선 수정 #42 노선 수정 Sep 4, 2020
노선 삭제 메소드 추가
노선 이름은 중복될 수 있으므로 추가시 체크하지 않도록 수정
Copy link
Member

@f-lab-dev f-lab-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 드린것만 확인해보시면 될 것 같습니다~

* @return ResponseEntity
*/
@LoginCheck(userLevel = UserLevel.ADMIN)
@PatchMapping()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거는 모든 정보를 수정하는 것 같은데 PATCH로 하신 이유가 있으실까요?

모든 정보를 수정하는 메소드 이므로 post 메소드로 수정
외부 사용자가 볼떄는 삭제 메소드 이므로 DeleteMapping으로 수정
#44 노선 추가시 이름 중복 여부 삭제
@0hun 0hun merged commit deca4e9 into issue/40 Sep 6, 2020
@0hun 0hun deleted the issue/42 branch September 6, 2020 13:28
@0hun 0hun restored the issue/42 branch September 7, 2020 09:48
@0hun 0hun deleted the issue/42 branch September 7, 2020 09:55
@0hun 0hun linked an issue Sep 9, 2020 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#42 노선 수정
2 participants