Fix monitor parent and add additional profiles #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TcpProfiles * TcpProfile * UdpProfiles * UdpProfile * HttpProfiles * HttpProfile * OneconnectProfiles * OneconnectProfile * HttpProfiles * HttpProfile
The management of monitors used a limited set of parent monitors, which in inaccurately restricts which parents are able to be used. Here we adjust that notion by adding a new monitorType field that is not included in the json, but used during the calls to create a monitor.
|
Do you accept PRs? Please let me know if you want community involvement. The upstream of this repo is a bit in flux, and I see the master has diverged here. My cohorts and I are willing to send code for the features we're expecting to use. Also, why are issues not allowed on this repo? |
zlesnr
force-pushed
the
f5improvements
branch
from
9787a0f to
65c6363
Compare
|
|
|
@zlesnr
yes we accept PRs very well I just commited
…On Wed, Dec 20, 2017 at 2:22 PM, zlesnr ***@***.***> wrote:
Do you accept PRs? Please let me know if you want community involvement.
The upstream of this repo is a bit in flux, and I see the master has
diverged here. My cohorts and I are willing to send code for the features
we're expecting to use.
Also, why are issues not allowed on this repo?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANN1yOCwlk87JVXjwTk1J1W2ot-cISu3ks5tCYi2gaJpZM4RJCgE>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.