-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django admin date_hierarchy linking is not working anymore #374
Comments
@jeroenpeters1986 thank you for having reported this issue! The error is raised here, so I'm pretty sure it's an issue related with the latest django version. If you can submit a PR with a backward-compatible fix that would be great! |
Hi @fabiocaccamo thank you for your fast reply! I will edit my PR tomorrow so that it will work on both versions :-) |
@jeroenpeters1986 yes, I saw that it doesn't pass the tests... |
Yes to honest I checked out the bug and fixed it locally, and with the diff I created the PR, not realizing you have other mechanism around it until I created the PR. So I need a bit of time but will check it out tomorrow (maybe Friday) and I will update it and let you know when I think it’s ready hahaOp 7 mrt 2024 om 00:38 heeft Fabio Caccamo ***@***.***> het volgende geschreven:
@jeroenpeters1986 yes, I saw that it doesn't pass the tests...
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@jeroenpeters1986 thanks for the PR, you can upgrade to |
Thanks so much! I will upgrade it tonight. Thanks so much for the awesome package, glad I could do something 'back' |
Python version
3.11
Django version
5.0.2
Package version
0.28.5
Current behavior (bug description)
I am using the "date_hierarchy" (https://docs.djangoproject.com/en/5.0/ref/contrib/admin/#django.contrib.admin.ModelAdmin.date_hierarchy) function on a Django model. With version 0.28.5 I am getting this error when I click on the Year
Expected behavior
It seems that the received params have changes and are now a list instead of the string from the URL
I will submit a PR, I am not sure if this is because of Django5 or earlier
Upvote & Fund
The text was updated successfully, but these errors were encountered: