-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(): Migrate json control tests #9323
Conversation
Build Stats
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a simple test migration.
controls13/14 golden is data
controls12 golden is data2 and I added a test for it with padding
…ic.js into migrate-json-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
At this point i want to know which part made you mad |
The tests were failing and I wanted to inspect the json. That made me made. |
fc96a3e
to
d67ba0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good, updated description
Motivation
I was working on #9148 and the tests drove me madEDIT:
We are switching to playwright also for snapshot testing since the manually maintained visual testing library isn't great.
While we are probably loosing node snapshot with this change, we do know that node renders boxes and lines very good and the point of this test was always just to keep an eye on control positions.EDITED: There doesn't seem to be a reason to test node because controls have no use in that env, however we can add also node snapshots once #9134 is merged
For the work i m doing around #9148 i m more comfortable with those tests in playwright
Description
Changes
Gist
In Action