Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

yury
Copy link
Contributor

@yury yury commented Dec 28, 2015

Allow ASNodeCell to specify pointInside of UITableViewCell.
This is very usefull, if ASNodeCell is presented as bubble aligned to
left or right (like Messages.app) and we need to be able to select row
only if user taps on bubble.

Allow ASNodeCell to specify pointInside of UITableViewCell.
This is very usefull, if ASNodeCell is presented as bubble aligned to
left or right (like Messages.app) and we need to be able to select row
only if user taps on bubble.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Should we bridge hitTest too? Will that work correctly with the logic already in ASDisplayNode that is used for hitTesting, if we bridge it directly to the node without a special implementation? (it should)

Bump the { on the next line to match the style, and I'm happy to merge this. Optionally, add a comment to the header indicating that this is supported.

@yury
Copy link
Contributor Author

yury commented Dec 29, 2015

@appleguy Please take a look at sample project. Works fine for me.

hitTest seems not in ASCellNode

@appleguy
Copy link
Contributor

@yury isn't hitTest implemented in ASDisplayNode, just like pointInside? Thanks for the brace fix!

@appleguy
Copy link
Contributor

I'll go ahead and merge this now so it makes the 1.9.4 release (launch for that release is looking like tomorrow evening - I don't want to rush my testing / writing the release notes, and it is getting late tonight for what I have to do in the morning).

If you do have the time to try it out, it would be great to see the hitTest version added unless you predict a problem that could cause. It should be another diff almost identical to this one, very short one-line implementation.

appleguy added a commit that referenced this pull request Dec 30, 2015
[ASCellNode] Forward pointInside to node implementation from UITableViewCell.
@appleguy appleguy merged commit cc15d74 into facebookarchive:master Dec 30, 2015
@appleguy
Copy link
Contributor

@yury I can't believe I didn't mention / notice this before, but - even more important than the hitTest: version, which is very helpful to be able to use something like hitTestSlop or other uses for hitTest: going to a specific subview, this same pointInside implementation should be added to the equivalent place in ASCollectionView!

@appleguy appleguy added this to the 1.9.4 milestone Dec 30, 2015
@appleguy appleguy changed the title Bridge UITableViewCell pointInside to ASNodeCell [ASCellNode] Forward pointInside to node implementation from UITableViewCell. Dec 30, 2015
@yury yury deleted the bridge-uitableviewcell-pointinside branch December 30, 2015 09:00
yxztj pushed a commit to iftechio/AsyncDisplayKit that referenced this pull request Sep 29, 2018
* Properly consider node for responder methods

* Add changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants