-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[ASCellNode] Forward pointInside to node implementation from UITableViewCell. #1008
[ASCellNode] Forward pointInside to node implementation from UITableViewCell. #1008
Conversation
Allow ASNodeCell to specify pointInside of UITableViewCell. This is very usefull, if ASNodeCell is presented as bubble aligned to left or right (like Messages.app) and we need to be able to select row only if user taps on bubble.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
AsyncDisplayKit/ASTableView.mm
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! Should we bridge hitTest too? Will that work correctly with the logic already in ASDisplayNode that is used for hitTesting, if we bridge it directly to the node without a special implementation? (it should)
Bump the { on the next line to match the style, and I'm happy to merge this. Optionally, add a comment to the header indicating that this is supported.
@appleguy Please take a look at sample project. Works fine for me.
|
@yury isn't hitTest implemented in ASDisplayNode, just like pointInside? Thanks for the brace fix! |
I'll go ahead and merge this now so it makes the 1.9.4 release (launch for that release is looking like tomorrow evening - I don't want to rush my testing / writing the release notes, and it is getting late tonight for what I have to do in the morning). If you do have the time to try it out, it would be great to see the hitTest version added unless you predict a problem that could cause. It should be another diff almost identical to this one, very short one-line implementation. |
[ASCellNode] Forward pointInside to node implementation from UITableViewCell.
@yury I can't believe I didn't mention / notice this before, but - even more important than the hitTest: version, which is very helpful to be able to use something like hitTestSlop or other uses for hitTest: going to a specific subview, this same pointInside implementation should be added to the equivalent place in ASCollectionView! |
* Properly consider node for responder methods * Add changelog
Allow ASNodeCell to specify pointInside of UITableViewCell.
This is very usefull, if ASNodeCell is presented as bubble aligned to
left or right (like Messages.app) and we need to be able to select row
only if user taps on bubble.