This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Ensure that the uncommon __unloadNode codepath does not unintentionally trigger node removal. #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly trigger node removal.
|
This ensures that shouldRasterizeDescendants can be enabled and disabled at app runtime even after a full sub-hierarchy of nodes has been loaded. This wasn't supported by ASDK for years, until early October 2015, and was recently broken by one of my changes about a week ago in master.. |
appleguy
added a commit
that referenced
this pull request
Dec 30, 2015
Ensure that the uncommon __unloadNode codepath does not unintentionally trigger node removal.
yxztj
pushed a commit
to iftechio/AsyncDisplayKit
that referenced
this pull request
Sep 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.