This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASDisplayNode convertRect:fromNode:] patch #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_calculateTransformFromReferenceToTarget()` was being called incorrectly! 👍
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Seems reasonable. cc @toulouse in case he wants to take a look. |
secretiverhyme
added a commit
that referenced
this pull request
Nov 14, 2014
[ASDisplayNode convertRect:fromNode:] patch
|
Looks good but make sure to check the test cases. Wonder why this wasn't caught. |
|
Changes Unknown when pulling 7307321 on aleclarson:patch-1 into * on facebook:master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_calculateTransformFromReferenceToTarget()was being called incorrectly! 👍Probably from copy-pasting
convertRect:toNode:'s implementation. 😜