This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASTextNode] Support iteratively shrinking font size in order to ensure no single words are wrapped. #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleguy
changed the title
lkzhao
force-pushed
the
ASTextKitFontSizeAdjuster
branch
from
1d64210 to
f37c805
Compare
|
This is the start of great things to come! Will merge after tests run. Thank you @lkzhao, very much. |
appleguy
added a commit
that referenced
this pull request
Jan 26, 2016
[ASTextNode] Support iteratively shrinking font size in order to ensure no single words are wrapped.
Merged
yxztj
pushed a commit
to iftechio/AsyncDisplayKit
that referenced
this pull request
Sep 29, 2018
…ve#1091) * Shouldn't hold the lock while adding subnodes * Add comments, good call @nguyenhuy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can specify a minimumScaleFactor on ASTextNode.
Then the ASTextRenderer will shrink the font size if there are words that doesn't fit in the container.
If the word is too long, i.e. even with the minimumScaleFactor applied, it sill doesn't fit in the container. Then it will fall back to the default font size.