[ASRangeControllerBeta] Scan all nodes after edit operations.

[appleguy]

@knopp, please do take a look! Is there any more efficient way you can think to do this? I'm particularly bummed about creating all the index paths - I think we could make an alternate codepath that iterates over the nodes themselves, keeping a local integer of section and item number, doing something like the multidimensional helper function does internally by building up the index path by index - but not having to create a full array of them. This might not help efficiency much, though it would also eliminate accessing the nodes out of the 2D array.

[knopp]

I hear you, but in the end, you still need to check
fetchDataIndexPaths, displayIndexPaths and visibleIndexPaths, and you need
NSIndexPaths for that, don’t you? And you need to do it for every single
item. But with separate code path you could maybe at least
avoid NSMutableOrderedSet overhead, which miight not be small if you have
thousands of index paths.

-Matej

On Mon, Jan 25, 2016 at 3:44 AM, appleguy notifications@github.com wrote:

@knopp https://github.com/knopp, please do take a look! Is there any
more efficient way you can think to do this? I'm particularly bummed about
creating all the index paths - I think we could make an alternate codepath
that iterates over the nodes themselves, keeping a local integer of section
and item number, doing something like the multidimensional helper function
does internally by building up the index path by index - but not having to
create a full array of them. This might not help efficiency much, though it

would also eliminate accessing the nodes out of the 2D array.

You can view, comment on, or merge this pull request online at:

#1105
Commit Summary

• [ASRangeControllerBeta] Scan all nodes after edit operations.

File Changes

• M AsyncDisplayKit/Details/ASRangeControllerBeta.mm
  https://github.com/facebook/AsyncDisplayKit/pull/1105/files#diff-0
  (4)

Patch Links:

• https://github.com/facebook/AsyncDisplayKit/pull/1105.patch
• https://github.com/facebook/AsyncDisplayKit/pull/1105.diff

—
Reply to this email directly or view it on GitHub
#1105.