This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASTextNode] Fix out-of-bounds error when truncation string is longer than the original string. #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually it is possible that truncated string is longer then original string. For example, original string: ``` hello this is very long message here and there ``` with maximumNumberOfLines=4, truncationAttributedString = ' ...' and additionalTruncationMessage = 'read more' will give ``` hello this is very long message here ... read more ``` So `[attributedString attribute:attributeName atIndex:characterIndex longestEffectiveRange:&range inRange:visibleRange]` will crash.
|
Also related to #1110 |
|
@yury thanks a lot for porting the other CK commits!! @ocrickard anything else we should be aware of? I wonder if there's a way to set up something similar to a Herald rule to notify me when text components change :) |
appleguy
changed the title
appleguy
added a commit
that referenced
this pull request
Jan 26, 2016
[ASTextNode] Fix out-of-bounds error when truncation string is longer than the original string.
|
@yury could you send me an example test case for this so I can integrate it into the unit tests? If you're able to add a snapshot / unit test for this directly, that would be phenomenal too :). asyncdisplaykit@gmail.com |
yxztj
pushed a commit
to iftechio/AsyncDisplayKit
that referenced
this pull request
Sep 29, 2018
…chive#1111) * fix SIMULATE_WEB_RESPONSE not imported facebookarchive#449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a10596622ff8a68835c95a23986d7bf61ea. * Fix interface state not update correctly during layer thrash * add change log
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually it is possible that truncated string is longer then original
string.
For example, original string:
with maximumNumberOfLines=4, truncationAttributedString = ' ...' and
additionalTruncationMessage = 'read more'
will give
So
[attributedString attribute:attributeName atIndex:characterIndex longestEffectiveRange:&range inRange:visibleRange]will crash.