Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Update Swift Example #1160

Merged
merged 7 commits into from
Feb 2, 2016
Merged

Update Swift Example #1160

merged 7 commits into from
Feb 2, 2016

Conversation

Adlai-Holler
Copy link
Contributor

  • Tweak Kittens to use dispatch_after rather than sleeping on a background thread.
  • Update Swift example to use_frameworks! instead of bridging from Objective-C. This is the preferred method.
  • Update Swift example project to latest recommended project settings.
  • Cherry-pick 819a09d from Resolve Build Error When use_frameworks! Option Set in CocoaPods #1158 so that it builds.
  • Rewrite the Swift example's view controller to use ASViewController and support batch-fetching and all-around get schwifty.

@appleguy
Copy link
Contributor

appleguy commented Feb 2, 2016

Awesome!! Thank you! Just made a Swift tag.

@appleguy appleguy added this to the 1.9.7 milestone Feb 2, 2016
appleguy added a commit that referenced this pull request Feb 2, 2016
@appleguy
Merge pull request #1160 from Adlai-Holler/AHUpdateSwiftExample
f1e0009 
[Swift] Update Swift Example, resolve build issue with some Swift projects.
@appleguy appleguy merged commit f1e0009 into facebookarchive:master Feb 2, 2016
@Adlai-Holler Adlai-Holler mentioned this pull request Feb 7, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Refactoring Swift
Projects
None yet
Milestone
1.9.7
Development

Successfully merging this pull request may close these issues.
3 participants
@Adlai-Holler @appleguy @facebook-github-bot