This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Assert that ASEditableTextNode stays view-backed #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Open bracket on newline.
Expand the comment below, by revising after the dash - "instances must be view-backed in order to ensure touch events can be passed to the internal UITextView during editing"
|
Thanks @adly-holler! Small stylistic change here, ready to merge after. |
|
Changes made! |
appleguy
added a commit
that referenced
this pull request
Sep 22, 2015
Assert that ASEditableTextNode stays view-backed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.