This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Fixing dynamic framework target and adding an example for Travis #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmelroy
changed the title
|
@marmelroy thanks man! Here I missed the file add once again. This is most definitely a job for a machine :). Sorry it took so much extra effort to get running with Carthage in a stable way. I'm very relieved to have this fixed once and for all. |
appleguy
added a commit
that referenced
this pull request
Oct 4, 2015
Fixing dynamic framework target and adding an example for Travis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of ASPhotosFrameworkImageRequest in ee0c027 broke the AsyncDisplayKit dynamic framework target. Again.
This is now fixed.
To prevent it from breaking again in the future, I created a new dynamic framework smoke test (based on the swift example). Travis will now build it and warn if there are any errors.