Adds support for disabling and re-enabling should rasterize. #711
Conversation
There was a problem hiding this comment.
This seems a little sparse, but smart :). Multiple loads and unloads of a node is a first for the public ASDK, something we had some challenges implementing a while back when building prototypes of view reuse. I assume each time will use layerBlock or viewBlock accordingly?
|
This is looking good, should be able to merge soon...any ideas on testing this? A couple unit tests would be warranted particularly for a change of this size. We're tracking unit test coverage now, and with the big new methods I think that will drop unless we add a couple, aside from the legitimate reasons to have them. Snapshot test may be appropriate using colored boxes. Try enabling shouldRasterize on the layout tests, which are already running against images of colored boxes? |
garrettmoon
force-pushed
the
addSupportForDisablingAndEnablingShouldRasterize
branch
from
c24e1a1 to
1a8f669
Compare
|
This diff is definitely on the scarier side for me, but I really trust your work! |
…blingShouldRasterize Adds support for disabling and re-enabling should rasterize.
3 participants
No description provided.