This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Document Cell Layout Passes #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per your comments in the other diff, I'd also support renaming the methods to be more -measure-centric, but the comments added here make it pretty clear. |
|
It looks like the FIXMEs here are squarely within the scope of the batch processing fixes that we need. I'm not sure who will be able to champion that work, but I think a couple folks were considering it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pursuant to #735, here's some more documentation! I added some questions in
FIXMEcomments.I also replaced two needless calls to
enumerateObjects:with NSFastEnumeration instead. I reckon every bit of performance counts!