This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Fix table view tests #770
Merged
Fix table view tests #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- During initial configuration of a table view with a zero size, for each cell, there is a mismatch between the widths of its content view and constrained size. However, don't relayout the cell immediately because an initial data loading will be performed shortly afterward.
- Add -triggerFirstLayoutMeasurementForTableView: - Move -triggerSizeChangeAndAssertRelayoutAllRowsForTableView:newSize to the end of the file.
nguyenhuy
force-pushed
the
FixTableViewTests
branch
from
14be074 to
7b71462
Compare
|
Awesome, thank you! |
5 tasks
aimalygin
pushed a commit
to aimalygin/AsyncDisplayKit
that referenced
this pull request
Feb 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in ASTableView that causes unnecessary relayout when the table view width is zero initially. This PR includes the fix for this bug and some minor refactorings.
#758, #753