This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Fix failing tests related to ASDisplayNode name #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 906d7c7.
- Backed by name of the underlying ASDisplayNode. - Remove goofy usages of `setValue:forKey:` in ASDisplayNodeTests and ASDisplayNodeAppearanceTests.
- They are neither considered internally nor in tests. And when they are accidently considered, they cause tests to fail. - Developers can easily set debugging names themselves whenever needed.
|
Since this PR contains a revert commit. I think it's easier to review commits individually. |
|
Wow, cool :) Will land as soon as the tests pass |
|
Nice! Thanks again @nguyenhuy |
|
You're welcome :) |
appleguy
added a commit
that referenced
this pull request
Oct 26, 2015
…yNodeName Fix failing tests related to ASDisplayNode name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#773