This repository was archived by the owner on Feb 2, 2023. It is now read-only.
adds convenience methods to return a vertical and horizontal stack spec #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be a better alternative to add an extra initializer to define the direction or a class method on ASStackLayoutSpec. |
samhsiung
force-pushed
the
name_stacks
branch
2 times, most recently
from
a468477 to
bdf7dc2
Compare
|
Good idea, added class methods instead. |
samhsiung
force-pushed
the
name_stacks
branch
from
bdf7dc2 to
6f1e23f
Compare
samhsiung
force-pushed
the
name_stacks
branch
from
6f1e23f to
29a1283
Compare
samhsiung
changed the title
|
I agree with @levi's suggestion, so thanks for jumping on that @samhsiung. This is implemented cleanly — even if the stack is subclassed by a public client, using [self alloc] and instancetype will ensure correct behavior. Cool! |
appleguy
added a commit
that referenced
this pull request
Oct 31, 2015
adds convenience methods to return a vertical and horizontal stack spec
aimalygin
pushed a commit
to aimalygin/AsyncDisplayKit
that referenced
this pull request
Feb 19, 2018
…rchive#796) * Add scrollViewWillEndDragging delegate * Make sure delegate can respond to scrollViewWillEndDragging * Add changes to CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It felt cumbersome to repeatedly specify the direction of an ASStackLayoutSpec so I thought it'd be nice to provide these convenience classes. I also ran into cases where I named an ASStackLayoutSpec as a verticalStack or horizontalStack but forgot to set it's direction causing me to waste time debugging.