This repository was archived by the owner on Feb 2, 2023. It is now read-only.
ensure all nodes are exited on dealloc #798
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is now superseded by #830 |
peter-iakovlev
pushed a commit
to peter-iakovlev/AsyncDisplayKit
that referenced
this pull request
Mar 12, 2018
… to invoke it manually instead of +load. (facebookarchive#798) * - [ASDisplayNode] Consolidate main thread initialization and allow apps to invoke it manually instead of +load. Additionally this has a few minor fixes for Yoga support, and adds some basic but universally valuable callbacks like -nodeDidLoad to ASNodeController. * Small fix for handling _layoutVersion. * Remove poking the scale accessor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a short-term fix for #797 and #791 suggested by @appleguy. I'm using a tweaked build of 1.2.3 and this seems to be working well for me. It clears any ASCellNodes that were in the Render state when the ASRangeController is dealloced (ultimately.) It is still possible for ASCellNodes to "leak" temporarily while the ASRangeController is alive. The good news is that this code will make sure it is cleaned up when the parent ASTable/CollectionView is dealloced.
I haven't tested this on master though (I'm not really set up for that at the moment), can someone give it a spin and make sure it plays well with all the amazing code in 1.9+?